Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps) update Electron to 24 #862

Merged
merged 2 commits into from
May 10, 2023
Merged

chore(deps) update Electron to 24 #862

merged 2 commits into from
May 10, 2023

Conversation

saghul
Copy link
Member

@saghul saghul commented May 9, 2023

No description provided.

@saghul saghul requested a review from csett86 May 9, 2023 16:04
@saghul
Copy link
Member Author

saghul commented May 9, 2023

@csett86 WDYT about landing this and making a new release? We haven't done one in a bit...

@csett86
Copy link
Member

csett86 commented May 9, 2023

I'll take a look tomorrow. I was holding back the electron upgrade as it will break screensharing on wayland (segfault on trying), but as it does not seem to get fixed, I will add a bigger warning in the readme as a known issue together with this PR

@saghul
Copy link
Member Author

saghul commented May 9, 2023

Thanks! Yeah that's unfortunate but 21 is EOLd so I think we have to upgrade.

Copy link
Member

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested successfully under mac OS 13, Windows 10. Linux works fine as well, apart from screensharing under wayland, which still segfaults. I will reopen #829 accordingly

@csett86 csett86 merged commit 8f34cca into master May 10, 2023
@csett86 csett86 deleted the update-deps branch May 10, 2023 17:23
d3473r pushed a commit to d3473r/jitsi-meet-electron that referenced this pull request Sep 1, 2023
* chore(deps) update Electron to 24
* docs: document broken screensharing on wayland

See jitsi#829

---------

Co-authored-by: Christoph Settgast <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants