feat(react-native): enable hermes engine #15279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Nov 7, 2024
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was succesfully scanned and it was determined that it does not contain any changes that present immediate security concerns. If you would still like for it to be reviewed by an expert from our reviewer community, you can submit it manually via the HackerOne PullRequest dashboard
Calinteodor
force-pushed
the
enable-hermes-engine
branch
2 times, most recently
from
e4de48b to
a532a16
Compare
Calinteodor
changed the title
Calinteodor
force-pushed
the
enable-hermes-engine
branch
from
37b5cef to
4ef9736
Compare
saghul
reviewed
Nov 22, 2024
android/sdk/src/main/java/org/jitsi/meet/sdk/ReactInstanceManagerHolder.java
Outdated
Show resolved
Hide resolved
android/sdk/src/main/java/org/jitsi/meet/sdk/ReactInstanceManagerHolder.java
Outdated
Show resolved
Hide resolved
android/sdk/src/main/java/org/jitsi/meet/sdk/ReactInstanceManagerHolder.java
Outdated
Show resolved
Hide resolved
Calinteodor
force-pushed
the
enable-hermes-engine
branch
from
4ef9736 to
9e5a54e
Compare
saghul
reviewed
Nov 22, 2024
saghul
reviewed
Nov 22, 2024
Calinteodor
force-pushed
the
enable-hermes-engine
branch
from
25ff543 to
eafa210
Compare
Calinteodor
force-pushed
the
enable-hermes-engine
branch
from
199d4ab to
6805d62
Compare
saghul
approved these changes
Nov 26, 2024
Calinteodor
changed the title
|
hermes and reat-native versions will be the same, so maybe no need to have a different hermesVersion variable |
|
Oh, is that so? Are they always released in tandem? |
|
Certainly looks that way: https://mvnrepository.com/artifact/com.facebook.react/hermes-android @Calinteodor can you remove the extra variable pl? @keremoge thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.