Fix undefined on formula toolbar selection #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a path error on Windows when looking for tests within the test folder.
Using the locale function now adds the specified language to the front of a list of languages which are searched for a translation string. This allows a primary language as well as one or more fallback languages. On initialization, the languages array contains only English---making English the default fallback. To clear the existing languages array upon specifying a language, set the clearLangList argument of the locale function to true.
If a locale messages key contains a '.' character, it must be escaped with a
backslash. Because the backslash character must itself be escaped with a
backslash, the proper way to write a key the includes a '.' character is:
{
"My\\.Key": "Value"
}
Some Excel formula names include a '.' character, so creating a translation
value using that formula name as a key requires support for '.' in keys.
Replace existing formula parsing and execution with an external parser library built on top of formula.js: https://github.com/handsontable/formula-parser This dramatically increases the number of supported formulas; see list here: https://formulajs.info/functions/
Formula keys within locale files should match the name of the formulajs
function that a translation string is being provided for.
If a formula name has a '.' in it, it should be escaped as follows:
{
"FORMULA\\.NAME": "TRANSLATION"
}
Absolute cell references are evaluated correctly. When dragging the bottom-right corner of a formula cell to copy its contents to other cells, absolute cell references will be incremented or decremented appropriately (only relative axes will be modified, not absolute). When adding or removing rows or columns, absolute cell references will be adjusted appropriately.
The initial click sets the cell reference range start position. If the click is held, the cell reference range end position is updated on mouse move. The cell reference range can then be modified in the same ways as a single cell reference (e.g., arrow keys).
If the user is editing a cell reference range within a formula and is holding the shift key while using the direction arrows to move the range, the start of the range will be fixed. This mirrors the behavior of Excel when editing a cell reference range.
|
I'm going to rebase this into the relevant commit in my PR that contains the bug and maintain your authorship. I'll do that instead of performing a PR merge. I'll close this PR when that action is complete. Thanks! |
jkirschner
force-pushed
the
formulajs-range-selection
branch
from
b70c5f9
to
8a2f8ff
Compare
jkirschner
force-pushed
the
formulajs-range-selection
branch
from
8a2f8ff
to
597b095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug reported in myliang#363 (comment)