-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-qt5.12.12-compatibility #127
Add-qt5.12.12-compatibility #127
Conversation
QList::swapItemsAt was introduced in Qt 5.13.
I'm not sure if I added this line correctly, but now it doesn't report errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR fix for issue #124
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is another problem. When I run .exe
s in build/output
directory, no window appears. Maybe there is something still wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! thanks for your PR ... I have only one comment:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
thanks for your PR ... I have only one comment:
Could you initialze the data members in the added default constructor in examples/libexampletools/jkqtpexampleapplication.h:
type(PlotterType), f(), plotf(), p(nullptr)
or simply change the following constructor by definig default arguments:inline Data(JKQTPlotter* p_=nullptr): type(PlotterType), f(), plotf(), p(p_) {}
Hi @jkriege2, I have added a default argument in Data's constructor. But still no window appear after I run .exe
s in build/output
directory.
OK, I will merge this for now and try how it works for me for Qt5.12.12 ... BTW: Which exammple did you try to run? Anything specific,or just any? |
Any example. |
strange ... I tried it on my computer with a freshly downloaded Qt 5.12.12 64bit and MinGW 7.3.0 in DEBUG and RELEASE ... and it works for my:
Can you compile in debug-mode and debug to check where the program hangs? |
I'm not sure if the modification in
examples\libexampletools\jkqtpexampleapplication.h
is correctly, but now it doesn't report errors.