Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-qt5.12.12-compatibility #127

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

Social-Mean
Copy link
Contributor

I'm not sure if the modification in examples\libexampletools\jkqtpexampleapplication.h is correctly, but now it doesn't report errors.

QList::swapItemsAt was introduced in Qt 5.13.
I'm not sure if I added this line correctly, but now it doesn't report errors.
Copy link
Contributor Author

@Social-Mean Social-Mean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fix for issue #124

Copy link
Contributor Author

@Social-Mean Social-Mean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is another problem. When I run .exes in build/output directory, no window appears. Maybe there is something still wrong.

Copy link
Contributor Author

@Social-Mean Social-Mean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkriege2
Copy link
Owner

Hi!

thanks for your PR ... I have only one comment:
Could you initialze the data members in the added default constructor in examples/libexampletools/jkqtpexampleapplication.h:

type(PlotterType), f(), plotf(), p(nullptr)
or simply change the following constructor by definig default arguments:

 inline Data(JKQTPlotter* p_=nullptr):
      type(PlotterType), f(), plotf(), p(p_)
  {}


Copy link
Contributor Author

@Social-Mean Social-Mean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

thanks for your PR ... I have only one comment:
Could you initialze the data members in the added default constructor in examples/libexampletools/jkqtpexampleapplication.h:

type(PlotterType), f(), plotf(), p(nullptr)
or simply change the following constructor by definig default arguments:

 inline Data(JKQTPlotter* p_=nullptr):
      type(PlotterType), f(), plotf(), p(p_)
  {}


Hi @jkriege2, I have added a default argument in Data's constructor. But still no window appear after I run .exes in build/output directory.

@jkriege2
Copy link
Owner

OK, I will merge this for now and try how it works for me for Qt5.12.12 ...

BTW: Which exammple did you try to run? Anything specific,or just any?

@jkriege2 jkriege2 merged commit be48ed8 into jkriege2:master Mar 18, 2024
1 check passed
@Social-Mean
Copy link
Contributor Author

Any example.

@jkriege2
Copy link
Owner

strange ... I tried it on my computer with a freshly downloaded Qt 5.12.12 64bit and MinGW 7.3.0 in DEBUG and RELEASE ... and it works for my:

[cmake] -- =============================================================================
[cmake] -- == JKQTPlotterLib Build Information                                        ==
[cmake] -- =============================================================================
[cmake] -- Version:               5.0.0
[cmake] -- CMake Generator:       Ninja
[cmake] --    is multi-config:    NO
[cmake] -- Build type:            Release
[cmake] -- Build types:           
[cmake] -- Build shared lib:      ON
[cmake] -- Using CMake:           3.27.7
[cmake] -- Using CMake Generator: Ninja
[cmake] -- Using compiler:        GNU 7.3.0, platform: MinGW
[cmake] -- C++ Standard:          C++ 11, required: TRUE
[cmake] -- LIB-Architecture:      CXX:  / BASE: 
[cmake] -- bit depth:             64 bit
[cmake] -- System Name:           Windows
[cmake] -- Processor Name:        AMD64
[cmake] -- Using Qt:              5.12.12
[cmake] --                        [at C:/development/Qt/5.12.12/mingw73_64/lib/cmake/Qt5]
[cmake] -- XITS fonts:            LINKED IN
[cmake] -- FIRA fonts:            LINKED IN
[cmake] -- Print support:         ON
[cmake] -- Timing Info output:    ON
[cmake] -- Precompiled Header:    ON
[cmake] -- build JKQTMath:        ON
[cmake] -- build JKQTMathText:    ON
[cmake] -- build JKQTFastPlotter: ON
[cmake] -- build JKQTPlotter:     ON
[cmake] -- Installing to:         C:/Program Files (x86)/JKQTPlotter
[cmake] -- =============================================================================
[cmake] -- 

Can you compile in debug-mode and debug to check where the program hangs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants