Add server url to global configuration #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 24, 2014 10:39
formated source code
fixed config
|
+1 for this functionality |
|
Not sure if this is a bug or not, but the plugin built from this fork is throwing an unknown host exception: https://gist.github.com/wjimenez5271/489ca5bb3b07b0612569 |
| } | ||
|
|
||
| @Override | ||
| public boolean configure(StaplerRequest sr, JSONObject formData) throws FormException { | ||
| server = sr.getParameter("hipChatServer"); |
There was a problem hiding this comment.
should keep the api.hipchat.com as a default if not set, for backward compatibility sake
|
@vralfy funny i just created a PR to add the same thing, I'll close mine out in favor of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My company got its own hipchat server. In order use that server I patched this plugin to set up hipchat server url in global definitions.