fix(csr): Set type of node_props to float64 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dtype` of `node_props` passed from `csr_to_nbgraph()` to `NBGraph` was `float32`. This sets the type to explicitly be `np.float64` which matches the expectation of `csr_spec_float` passed to `numba.experimental.jitclass()`.
This was referenced Oct 30, 2024
|
Cool, thanks for the investigation @ns-rse! Do you think you could copy over the failing test from TopoStats to make sure we don't get a regression here? |
|
Sure, I'm working on a different project for remainder of the week and then on annual leave for a week so won't be for a little while but happy to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dtypeofnode_propspassed fromcsr_to_nbgraph()toNBGraphwasfloat32. This sets the type to explicitly benp.float64which matches the expectation ofcsr_spec_floatpassed tonumba.experimental.jitclass().The tests that were previously failing in TopoStats (see #234 for details) now pass locally. 🙂
Closes #234