WIP: Supply cert for client #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to enable the use of certfp in IRC::Client. It is based upon the OpenSSL documentation found here: https://www.openssl.org/docs/man1.0.2/ssl/SSL_CTX_use_certificate_file.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP, since there's still a failing test left!
I'm looking to implement
certfpfunctionality intoIRC::Client, and after some reading and discussing I've found that this requires support forSSL_CTX_use_certificate_file. This is already available on.listen, but not yet for.connect. This PR intends to make such functionality available for.connectas well.The command-line version of this option would be
-cert, which can be used as follows:Now, I'm not terribly familiar with this particular module, or
ssllibin general, so any feedback would be greatly appreciated.