Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using iconify for icons for quick links #669

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/widgets/links/Display.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { FC, useMemo } from "react";
import { defineMessages, useIntl } from "react-intl";

import { Icon } from "../../../views/shared";
import { Icon } from '@iconify-icon/react';
import { Link } from "./types";

const displayUrl = (url: string): string => {
Expand Down Expand Up @@ -67,7 +67,7 @@ const Display: FC<Props> = ({ icon, name, number, url, linkOpenStyle }) => {
</i>
) : null
) : icon ? (
<Icon name={icon} />
<Icon icon={icon} />
) : null}
{icon && name && " "}
<span className="LinkText">
Expand Down
6 changes: 3 additions & 3 deletions src/plugins/widgets/links/Input.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import icons from "feather-icons/dist/icons.json";
import { listIcons } from 'iconify-icon';
import React, { FC } from "react";

import {
Expand All @@ -17,7 +17,7 @@ type Props = Link & {
onRemove: () => void;
};

const iconList = Object.keys(icons);
const iconList = listIcons;

const Input: FC<Props> = (props) => (
<div className="LinkInput">
Expand Down Expand Up @@ -67,7 +67,7 @@ const Input: FC<Props> = (props) => (
>
<option value={""}>None</option>
<option value="_favicon">Website Icon</option>
<optgroup label="Feather Icons">
<optgroup label="Icons via Iconify">
{iconList.map((key) => (
<option key={key}>{key}</option>
))}
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/widgets/links/Links.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { FC } from "react";

import { useKeyPress, useToggle } from "../../../hooks";
import { Icon } from "../../../views/shared";
import { Icon } from '@iconify-icon/react';
import Display from "./Display";
import { Props, defaultData } from "./types";
import "./Links.sass";
Expand Down Expand Up @@ -41,7 +41,7 @@ const Links: FC<Props> = ({ data = defaultData }) => {
))
) : (
<a onClick={toggleVisible} title="Show quick links">
<Icon name="link-2" />
<Icon icon="fe:insert-link" />
</a>
)}
</div>
Expand Down
27 changes: 0 additions & 27 deletions src/views/shared/icons/Icon.tsx

This file was deleted.