PUT Implementation Modifications #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the OAuth 1.0 specification has been extended See http://tools.ietf.org/html/rfc5849#appendix-A Therefore, the current behavior of the library should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OAuth spec only specifies that HTTP POST url-encoded parameters should be added to the signature base string. Therefore, these lines correctly implement the PUT protocol within OAuth:
https://github.com/simplegeo/python-oauth2/blob/master/oauth2/__init__.py#L646-648
However, the library parses the body for the signature whenever the content type is x-www-form-urlencoded on any type of request, not only POST as specified in the OAuth specs. This change enforces that the signature base includes the url-encoded parameters only on POST requests.