-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm compatibility, console testability & pre-generated parser #2
base: master
Are you sure you want to change the base?
Conversation
1. npm compatibility The core filtrex library has been modified so it can be installed and require()’d by node.js projects. The previous primary build artifact `filtrex.js` (and new filtrex.min.js) remains as a UMD-compatible module, generated by browserify (and uglify-js). 2. Console testability The test suite has been minimally modified to allow the running of tests via `npm test`. 3. Pre-generated parser To improve runtime efficiency and file-size, the Jison parser is precompiled into src/parser.js.
+1 I could use this. A bower config would be nice, too. |
Thanks for this. I tried the examples and they don't seem to work. I don't see any loading errors or JS console errors. Any idea what's happening? Does any of this stuff affect end users? If so, can you add it to the README. Thanks |
Sorry my bad I had misnamed the exported function - please retry. There should be no change for end users. |
Makefile doesn't work out of the box: $ make |
@joewalnes, |
That should be in the makefile. On Thu, May 15, 2014 at 9:40 PM, Sean Brewer [email protected]:
|
@jaz303 @joewalnes OK, how about something like this?: https://gist.github.com/seabre/d9dc5039ff9f31471934 |
…d modules are missing
The core filtrex library has been modified so it can be installed and
require()’d by node.js projects. The previous primary build artifact
filtrex.js
(and new filtrex.min.js) remains as a UMD-compatible module,generated by browserify (and uglify-js).
The test suite has been minimally modified to allow the running of tests via
npm test
.To improve runtime efficiency and file-size, the Jison parser is precompiled
into src/parser.js.