Merge branch 'master' into feat/issue-provider-rework

* master:
  fix: edge case when creating new tags together with existing tags in short syntax
  Update README.md
  Add mention of sync in app summary
  build: add missing dep 2?

README.md

@@ -104,6 +104,7 @@
   - Need some extra focus? A **Pomodoro timer** is also always at hand.
   - **Collect personal metrics** to see, which of your work routines need adjustments.
 - Integrate with **Jira**, **GitHub**, **GitLab**, **Gitea** and **OpenProject**. Auto import tasks assigned to you, plan the details locally, automatically create work logs, and get notified immediately, when something changes.
+- Back up and synchronize your data across multiple devices with **Dropbox** and **WebDAV** support
 - Attach context information to tasks and projects. Create **notes**, attach **files** or create **project-level bookmarks** for links, files, and even commands.
 - Super Productivity **respects your privacy** and **does NOT collect any data** and there are no user accounts or registration. **You decide where you store your data!**
 - It's **free** and **open source** and always will be.

src/app/features/tasks/short-syntax.spec.ts

@@ -428,6 +428,28 @@ describe('shortSyntax', () => {
       });
     });
 
+    it('should work for edge case #3728', () => {
+      const t = {
+        ...TASK,
+        title: 'Test tag error #testing #someNewTag3',
+        tagIds: [],
+      };
+      const r = shortSyntax(t, CONFIG, [
+        ...ALL_TAGS,
+        { ...DEFAULT_TAG, id: 'testing_id', title: 'testing' },
+      ]);
+
+      expect(r).toEqual({
+        newTagTitles: ['someNewTag3'],
+        remindAt: null,
+        projectId: undefined,
+        taskChanges: {
+          title: 'Test tag error',
+          tagIds: ['testing_id'],
+        },
+      });
+    });
+
     it('should not add new "asd #asd" tag when disabled', () => {
       const t = {
         ...TASK,

src/app/features/tasks/store/short-syntax.effects.ts

@@ -156,7 +156,9 @@ export class ShortSyntaxEffects {
         }
 
         if (r.newTagTitles.length) {
-          actions.push(addNewTagsFromShortSyntax({ task, newTitles: r.newTagTitles }));
+          actions.push(
+            addNewTagsFromShortSyntax({ taskId: task.id, newTitles: r.newTagTitles }),
+          );
         }
 
         if (tagIds && tagIds.length) {
@@ -184,7 +186,7 @@ export class ShortSyntaxEffects {
       ofType(addNewTagsFromShortSyntax),
       // needed cause otherwise task gets the focus after blur & hide
       tap((v) => this._layoutService.hideAddTaskBar()),
-      concatMap(({ task, newTitles }) => {
+      concatMap(({ taskId, newTitles }) => {
         return this._matDialog
           .open(DialogConfirmComponent, {
             restoreFocus: true,
@@ -205,7 +207,9 @@ export class ShortSyntaxEffects {
           })
           .afterClosed()
           .pipe(
-            mergeMap((isConfirm: boolean) => {
+            // NOTE: it is important to get a fresh task here, since otherwise we might run into #3728
+            withLatestFrom(this._taskService.getByIdOnce$(taskId)),
+            mergeMap(([isConfirm, task]) => {
               const actions: any[] = [];
               if (isConfirm) {
                 const newTagIds = [...task.tagIds];

src/app/features/tasks/store/task.actions.ts

@@ -268,7 +268,7 @@ export const addNewTagsFromShortSyntax = createAction(
   TaskActionTypes.AddNewTagsFromShortSyntax,
 
   props<{
-    task: Task;
+    taskId: string;
     newTitles: string[];
   }>(),
 );