Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show autocomplete when using short syntax for tags #3234

Merged
merged 8 commits into from
Jul 6, 2024

Conversation

bytrangle
Copy link
Contributor

Description

When user types the content of the new task and include the hash symbol (short syntax for tag), an autocomplete dropdown will open with a list of available tags. Users can click to select the tag and the tag title will be inserted into the input.

Issues Resolved

resolves #3224

Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@bytrangle
Copy link
Contributor Author

bytrangle commented Jun 26, 2024

ng lint failed because autocomplete-dropdown.e2e.ts has object properties that don't follow the naming conventions of ["camelCase", "snake_case", "UPPER_CASE", "PascalCase"].

In my local branch, I added a filter to pass ng lint.

        "@typescript-eslint/naming-convention": [
          "error",
          {
            "selector": "default",
            "format": ["camelCase", "snake_case", "UPPER_CASE", "PascalCase"],
            "leadingUnderscore": "allowSingleOrDouble",
            "trailingUnderscore": "allow",
            "filter": {
              "regex": "(should)|@tags",
              "match": false
            }
          },
        ]

Is it correct?

@johannesjo
Copy link
Owner

Is it correct?

Looks good to me! :)

@johannesjo
Copy link
Owner

Works great! Thank you very much!

@johannesjo johannesjo merged commit 89e06ff into johannesjo:master Jul 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete Dropdown for Tag Selection When Adding New Task
2 participants