-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Today Remaining in the projects view #3412
feat: Add Today Remaining in the projects view #3412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there shafiahmed12! 👋
Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖
We will try to review it soon!
Thank you very much! I've to say that – while certainly useful – it feels a bit cluttered with 4 entries and also the display logic of when to display icons instead does not work well with 4 entries. Maybe it is better to just show this info on hover using matTooltip? What do you think? |
I think that is a good idea, do you want this on hover on estimate remaining? |
Yes and yes :) thank you! |
made the changes as requested hope you are okay with this one :) |
Thank you very much! I like it a lot! :) |
This was my very first contribution and thanks for the confidence boost ✌ |
Thank you both for your outstanding contributions! |
Yes, why not! PRs are welcome! :)
PRs are welcome for this! :) |
I'm glad to help, but I'm not very familiar with TypeScript. Maybe I'll try starting with the pin feature since it seems simpler. |
Description
Filtering the tasks present in the projects and passing it to the mapEstimateRemainingFromTasks method so that the remaining time is calculated only for the tasks that are added to today
Describe what this change achieves
Issues Resolved
#3221
How it looks with this fix
Nothing is shown on Today page
Check List