Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Today Remaining in the projects view #3412

Merged

Conversation

shafiahmed12
Copy link
Contributor

@shafiahmed12 shafiahmed12 commented Sep 7, 2024

Description

Filtering the tasks present in the projects and passing it to the mapEstimateRemainingFromTasks method so that the remaining time is calculated only for the tasks that are added to today
Describe what this change achieves

Issues Resolved

#3221

How it looks with this fix

image
image

Nothing is shown on Today page

image

Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there shafiahmed12! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@johannesjo
Copy link
Owner

Thank you very much! I've to say that – while certainly useful – it feels a bit cluttered with 4 entries and also the display logic of when to display icons instead does not work well with 4 entries. Maybe it is better to just show this info on hover using matTooltip? What do you think?

@shafiahmed12
Copy link
Contributor Author

shafiahmed12 commented Sep 9, 2024

Thank you very much! I've to say that – while certainly useful – it feels a bit cluttered with 4 entries and also the display logic of when to display icons instead does not work well with 4 entries. Maybe it is better to just show this info on hover using matTooltip? What do you think?

I think that is a good idea, do you want this on hover on estimate remaining?
One more question what happens when we are in today page, The tooltip does not make sense in today page I think we still need to render it conditionally

@johannesjo
Copy link
Owner

Yes and yes :) thank you!

@shafiahmed12
Copy link
Contributor Author

Yes and yes :) thank you!

made the changes as requested hope you are okay with this one :)

@johannesjo
Copy link
Owner

Thank you very much! I like it a lot! :)

@shafiahmed12
Copy link
Contributor Author

Thank you very much! I like it a lot! :)

This was my very first contribution and thanks for the confidence boost ✌

@johannesjo johannesjo merged commit a1cd7a2 into johannesjo:master Sep 13, 2024
5 checks passed
@shafiahmed12 shafiahmed12 deleted the shafiahmed12-add-today-remaining branch September 13, 2024 11:34
@chenw191
Copy link

Thank you both for your outstanding contributions!
I noticed this new feature in the changelog, but it seems a bit too hidden. If I hadn't read the changelog and pull request, I wouldn't have discovered it. Is it possible to have it pop up automatically when I click "Add to/Remove from Today"? This might help more people notice it.
Also, I still need to move my mouse back and forth to check today's remaining tasks. Would it be possible to add a pin feature for this?

@johannesjo
Copy link
Owner

Is it possible to have it pop up automatically when I click "Add to/Remove from Today"? This might help more people notice it

Yes, why not! PRs are welcome! :)

Also, I still need to move my mouse back and forth to check today's remaining tasks. Would it be possible to add a pin feature for this?

PRs are welcome for this! :)

@chenw191
Copy link

Is it possible to have it pop up automatically when I click "Add to/Remove from Today"? This might help more people notice it

Yes, why not! PRs are welcome! :)

Also, I still need to move my mouse back and forth to check today's remaining tasks. Would it be possible to add a pin feature for this?

PRs are welcome for this! :)

I'm glad to help, but I'm not very familiar with TypeScript. Maybe I'll try starting with the pin feature since it seems simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants