Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds conversion of DCML harmony labels to Dezrann format #102

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

johentsch
Copy link
Owner

@johentsch johentsch commented Sep 11, 2023

As laid out in #47. This is a rebased version of the dezrann branch which has been deleted. Many thanks to @pythouille!

johentsch and others added 27 commits September 11, 2023 19:24
collab with Louis Couturier
…atment; enables deactivating the default layers by passing 0
…onto beat 1 of each alternative ending (volta); also prepares the function for creating labels pertaining to the various layers
@johentsch johentsch linked an issue Sep 11, 2023 that may be closed by this pull request
11 tasks
@johentsch
Copy link
Owner Author

Hi @pythouille, I'm under the impression that the measure_map.py file might not be needed within ms3 anymore. With the MeasureMap object that we're currently drafting it should be a no-brainer to create it from a ms3 measures TSV and then output it as JSON from there compressed or uncompressed etc.

I think a more systematic way for including the two conversions (to .dez and to .mm.json) would be to ditch the idea of making them independent from ms3 and to include them as additional options to the ms3 transform commandline tool. Then we can include the measuremaps code as a submodule and avoid duplicating too much. That also conforms better to our idea that the compression algorithm should live at one particular place only.

There is a draft of a simplified compression algorithm that simply compares a MM entry with the expected default generated from the previous entry (in other words, correctly reconstructing it in the first place is the guarantee that it can be omitted).

Do you agree with these things? Would you mind comparing the rules constructed over there in the function make_default_successor() with your code here and report/commit if you feel changes are due?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export to .dez format [FEATURE]
2 participants