This repository has been archived by the owner on May 18, 2022. It is now read-only.
External code can't access Consume fields, and thus can't implement Consumer #145
Labels
status: needs code
An implementation or a bugfix need to be written
type: bug
Something isn't behaving as intended
I ran into this when copying over the implementation from #137 into a crate outside of
rubble
- it looks likeConsume
, the type used for conveying results toConsumer
, has private fields only accessible to rubble. Unless I'm missing a way to get intoConsume::consume
andConsume::result
, this prevents outside users from implementing queues built to their needs.I think this could be fixed pretty easily by either making fields public (maybe with an adding private
()
field for forward compatibility), or by adding accessors. If it's alright, I'll submit a PR - I mildly favor accessors, but since rubble's still pre-1.0
, andConsume
is fairly feature-complete for what it is, it probably doesn't matter a ton?The text was updated successfully, but these errors were encountered: