This repository has been archived by the owner on May 18, 2022. It is now read-only.
Add accessors to Consume #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows properly implementing Consumer to create new queue implementations outside of the rubble crate. Signed-off-by: David Ross <[email protected]>
rubble/src/link/queue.rs
Outdated
| &self.result | ||
| } | ||
|
|
||
| /// Unwraps this [`Consume`], retrieving the inner result. |
There was a problem hiding this comment.
The link doesn't go anywhere
There was a problem hiding this comment.
Right. I'm not entirely sure what I was thinking with this, thanks for catching it!
rubble/src/link/queue.rs
Outdated
| @@ -190,6 +190,21 @@ impl<T> Consume<T> { | |||
| result, | |||
| } | |||
| } | |||
|
|
|||
| /// Retrieves whether this consume represents consuming a packet or not. | |||
There was a problem hiding this comment.
Suggested change
| /// Retrieves whether this consume represents consuming a packet or not. | |
| /// Retrieves whether the packet should be removed from the queue. |
rubble/src/link/queue.rs
Outdated
| @@ -190,6 +190,21 @@ impl<T> Consume<T> { | |||
| result, | |||
| } | |||
| } | |||
|
|
|||
| /// Retrieves whether this consume represents consuming a packet or not. | |||
| pub fn consume(&self) -> bool { | |||
There was a problem hiding this comment.
Maybe should_consume would be better? Feel free to rename the field to match as well.
added 3 commits
August 14, 2020 05:43
Signed-off-by: David Ross <[email protected]>
Signed-off-by: David Ross <[email protected]>
Signed-off-by: David Ross <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145
I haven't thought a ton about the naming of these methods, but they should work alright.