Remove the #none command since #only= with no ids is doing the job

jonathanperret · Sep 23, 2018 · 09b62ea · 09b62ea
1 parent 6f3b0f8
commit 09b62ea
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/public/paysagerenderer/visibility_management.js b/public/paysagerenderer/visibility_management.js
@@ -5,10 +5,8 @@ const ONLY_COMMAND = '#only=';
 
 Paysage.readIdsFromUrlHash = function (urlHash) {
   if (urlHash.startsWith(ONLY_COMMAND)) {
-    return urlHash.substring(ONLY_COMMAND.length).split(',');
-  }
-  if (urlHash === '#none') {
-    return [];
+    var idsList = urlHash.substring(ONLY_COMMAND.length);
+    return idsList === '' ? [] : idsList.split(',');
   }
   return undefined;
 };

diff --git a/spec/public/paysagerenderer/visibility_management_spec.js b/spec/public/paysagerenderer/visibility_management_spec.js
@@ -6,7 +6,7 @@ describe('The Paysage renderer visibility management', function () {
     expect(Paysage.readIdsFromUrlHash('#')).toEqual(undefined);
     expect(Paysage.readIdsFromUrlHash('#only=toto')).toEqual(['toto']);
     expect(Paysage.readIdsFromUrlHash('#only=toto,titi')).toEqual(['toto', 'titi']);
-    expect(Paysage.readIdsFromUrlHash('#none')).toEqual([]);
+    expect(Paysage.readIdsFromUrlHash('#only=')).toEqual([]);
   });
 
   describe('has code object filtering', function () {