Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More polish for CFGTOOL's UI #5121

Merged
merged 7 commits into from
Jul 13, 2024
Merged

More polish for CFGTOOL's UI #5121

merged 7 commits into from
Jul 13, 2024

Conversation

aybe
Copy link
Collaborator

@aybe aybe commented Jul 13, 2024 •
edited
Loading

Does this PR introduce new feature(s)?

Before:

image

Now:

image

Additional information

  • cleaner ignores
  • buttons all equally sized (height) -> vertical space reclaimed
  • fixed cropped focus on "..."
  • DRY-ed property editors -> UI more homogenous
  • widened editors to fit very large properties
  • more use of theme constants -> margins

Bonus: these controls position themselves dynamically now

@joncampbell123 joncampbell123 merged commit 5d1d451 into joncampbell123:master Jul 13, 2024
20 checks passed
@aybe aybe deleted the fixups branch July 13, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aybe @joncampbell123