-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Tooltips indicating the kind of error #213
base: master
Are you sure you want to change the base?
Conversation
@gstark0 can you fix the style/formatting to make it look good with the rest of the interface ? |
@ftyers How about this design? I chose the colors to match the toolbar at the top. |
Looks better... and it only appears when you hover over the warning sign right? |
@ftyers Nope... yet. That's the whole problem here, Cytoscape doesn't support label events (I read somewhere it's because of performance), I'm still figuring out how to handle this :< I also asked question about this, no answer yet. Right now it's on arc hover :( |
@gstark0 ok, let's pause this one until we get an answer. :) |
@ftyers Okay, I will try to figure out something myself meanwhile. |
Btw, should this also appear when cycle is detected? |
Yeah, but in that case maybe it would be nice to have it nearer the arc than the label. |
@ftyers Okay. How about some alternative solutions for the hover issue, maybe removing the icon (or placing it before label, like left arrow), tooltip can appear on arc hover then, and can be dismissed by just clicking anywhere inside the tooltip(could be highlighted) or button inside tooltip? |
@ftyers Take a look at this video I made(converted to gif, its pretty slow :<), it shows how this works now. I know it's not what you wanted, but it's as close as I could get right now. I went through the documentation of Cytoscape, but haven't found anything that would suit this issue, seems like not possible without modifying Cytoscape's code (although I'm still waiting for the answer on stackoverflow). It's not that intuitive unfortunately, as it could be with hover over icon :< |
c8c83a7
to
b6180dc
Compare
[Work In Progress]
Currently added warning icon to graph that indicates if there is any error with deprel.
Update: I integrated Qtip with Cytoscape to display warnings :) Unfortunately, Cytoscape does not allow for too many custom added features :(
@ftyers @maryszmary Let me know what you think.