Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Tooltips indicating the kind of error #213

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gstark0
Copy link
Contributor

@gstark0 gstark0 commented Jan 11, 2018

[Work In Progress]
Currently added warning icon to graph that indicates if there is any error with deprel.

Update: I integrated Qtip with Cytoscape to display warnings :) Unfortunately, Cytoscape does not allow for too many custom added features :(

@ftyers @maryszmary Let me know what you think.

screen shot 2018-01-11 at 20 21 21

screen shot 2018-01-11 at 18 56 11

@gstark0 gstark0 changed the title [WIP] Warning icon if error [WIP] Tooltips indicating the kind of error Jan 11, 2018
@ftyers
Copy link
Collaborator

ftyers commented Jan 12, 2018

@gstark0 can you fix the style/formatting to make it look good with the rest of the interface ?

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 12, 2018

@ftyers How about this design? I chose the colors to match the toolbar at the top.
screen shot 2018-01-12 at 15 59 35
screen shot 2018-01-12 at 15 59 00

@ftyers
Copy link
Collaborator

ftyers commented Jan 12, 2018

Looks better... and it only appears when you hover over the warning sign right?

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 12, 2018

@ftyers Nope... yet. That's the whole problem here, Cytoscape doesn't support label events (I read somewhere it's because of performance), I'm still figuring out how to handle this :< I also asked question about this, no answer yet. Right now it's on arc hover :(

@ftyers
Copy link
Collaborator

ftyers commented Jan 12, 2018

@gstark0 ok, let's pause this one until we get an answer. :)

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 12, 2018

@ftyers Okay, I will try to figure out something myself meanwhile.

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 12, 2018

Btw, should this also appear when cycle is detected?

@ftyers
Copy link
Collaborator

ftyers commented Jan 12, 2018

Yeah, but in that case maybe it would be nice to have it nearer the arc than the label.

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 12, 2018

@ftyers Okay. How about some alternative solutions for the hover issue, maybe removing the icon (or placing it before label, like left arrow), tooltip can appear on arc hover then, and can be dismissed by just clicking anywhere inside the tooltip(could be highlighted) or button inside tooltip?

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 12, 2018

@ftyers Take a look at this video I made(converted to gif, its pretty slow :<), it shows how this works now. I know it's not what you wanted, but it's as close as I could get right now. I went through the documentation of Cytoscape, but haven't found anything that would suit this issue, seems like not possible without modifying Cytoscape's code (although I'm still waiting for the answer on stackoverflow). It's not that intuitive unfortunately, as it could be with hover over icon :<
EDIT: I found library, which was creating HTML labels for Cytoscape(which I could possibly attach to Qtip), but when I integrated it with Annotatrix, it was slow as hell, not to mention a lot of bugs :(
ud2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants