-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] mod_menu php fixes #44318
base: 5.2-dev
Are you sure you want to change the base?
[5.2] mod_menu php fixes #44318
Conversation
I have tested this item 🔴 unsuccessfully on 5f70630 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44318. |
I change this to draft as the behaviour with recover seems to be wrong. |
…to admin-mod-menu-fixes
I have tested this item ✅ successfully on d62377f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44318. |
This video shows that the recovery mode does not work. chrome_tUW7ufmkPe.mp4 |
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44318. |
I think, it would be more clear, instead of your variable define of camel-case $itemLink:
change to:
|
@brianteeman I have re-opened your issue. This PR is a partial fix for PHP warnings but does not resolve the issue with recovery mode. |
@brianteeman do you remember which version was correct? |
Pull Request for Issue #44317 (partial fix for php warnings)
Summary of Changes
Set Variables correctly
Testing Instructions
see #44317
Actual result BEFORE applying this Pull Request
Deprecated messages and Undefined Property messages
Expected result AFTER applying this Pull Request
no messages
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed