Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all the "Selection Tools" functions optional and configurable #754

Conversation

PeterDaveHello
Copy link
Contributor

🎉

@PeterDaveHello PeterDaveHello force-pushed the MakeAllSelectionToolsOptional branch from f3315a9 to bcbbc6b Compare July 20, 2024 17:53
@josStorer
Copy link
Owner

This part was actually deliberately removed because it is now possible to customize selection tools, and too many translation tools seem a bit messy.

@PeterDaveHello
Copy link
Contributor Author

This part was actually deliberately removed because it is now possible to customize selection tools, and too many translation tools seem a bit messy.

That's exactly the reason why I want them to be optional 😆

@josStorer
Copy link
Owner

I lean towards only keeping some particularly necessary tools as presets, such as translating any language into the user's language, and translating any language into the internationally common English. For other needs, users can customize directly, and there is no need to add more built-in presets.

@PeterDaveHello
Copy link
Contributor Author

So this patch will make both the "Translate (To Chinese)" & "Translate (Bidirectional)" functions not directly enabled, so it should be good with the idea? Or do you mean you'd entirely redesign this part of the feature? Thanks.

@PeterDaveHello
Copy link
Contributor Author

My current point is that there are two options that can't be turned off which may cause me to click the wrong one or decrease the efficiency in selecting the right one 😆

Screenshot:
image

@josStorer
Copy link
Owner

You can export all data and edit the activeSelectionTools field, clear out the old preset tools, and then re-import.

image

@PeterDaveHello
Copy link
Contributor Author

Just to clarify, is this extra step only necessary for existing users? It seems like a fresh install wouldn't have this issue, right? If that's the case, then we can close this PR for sure! Thanks!

@josStorer
Copy link
Owner

@PeterDaveHello This step is only needed by a very small number of users, as only in specific versions were these two options set to be enabled, and in many versions since then they have been turned off by default. If you have never modified the activated tools, or have never activated these two tools, then upgrading to the new version will not encounter this problem.

@PeterDaveHello
Copy link
Contributor Author

Got it, thanks again!

@PeterDaveHello PeterDaveHello deleted the MakeAllSelectionToolsOptional branch August 9, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants