Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update workflows #63

wants to merge 2 commits into from

Conversation

joshprzybyszewski
Copy link
Owner

What broke / What you're adding

Now that our React app is gonna be used more and more, I figured it's time to update our github workflows to reflect that.

How you did it

  1. I changed the golang specific workflows to only run on golang changes.
  2. I followed the example of this article to implement new workflows for react.js

How to test it and how to try to break it

Notice that the golang nor react workflows don't run on this PR but the docker build image still doe

Comment on lines +21 to +22
- name: Yarn Test
run: yarn test --watchAll=false
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #64 because we don't have any react tests for this new workflow to run

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:oof:

steps:
- uses: actions/checkout@v1
- name: Install Dependencies
run: yarn
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using npm. Will using yarn in our actions cause problems?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I have no idea. It seems to work, but 🤷 . We should probably hold off on this until we actually have unit tests in js too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants