Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded the package to compatible with laravel version 10 #11

Closed
wants to merge 1 commit into from

Conversation

snakindia
Copy link

No description provided.

@joskfg
Copy link
Owner

joskfg commented Oct 20, 2024

Hello @snakindia,

Thanks for you PR, but a lot of tests are failing:

PHPUnit 10.5.37 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.12
Configuration: /app/phpunit.xml

EEEE..E.EEE...............EE.E..E..EE....EEE.....                 49 / 49 (100%)

Time: 00:00.505, Memory: 40.50 MB

There was 1 PHPUnit test runner warning:

1) No code coverage driver available

--

There were 17 errors:

Please fix them to be able to start checking that all is as expected.

Please, adapt the workflow action to use PHP 8.3 too to be able to have a pass build.

@snakindia snakindia closed this Oct 22, 2024
@snakindia snakindia deleted the topic branch October 22, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants