forked from microsoft/semantic-kernel
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
.Net: Fixed ReSharper/Rider errors to be compliant with dotnet format…
…ting settings (microsoft#5862) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Related to microsoft#4653 Before changes, VS studio with resharper or Rider showed many errors and warnings. But without resharper, VS studio shows 0 errors and 0 warnings like on screenshot. ![vs_studio_without_resharper](https://github.com/microsoft/semantic-kernel/assets/60486987/90824f8d-5273-453d-9a60-9f3e5010a21a) For Rider/Resharper (errors only): ![rider_errors_before](https://github.com/microsoft/semantic-kernel/assets/60486987/53eff93b-a036-4b8c-911f-9e4b4ebc8205) ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Now, after changes in .editorconfig for these developers which are using resharper/rider will show only resharper warnings, errors are empty like in VS studio. ![rider_errors_after](https://github.com/microsoft/semantic-kernel/assets/60486987/46cab9b6-6df4-4e8c-9a18-814be129c467) All disabled or changed to suggestion/warning rules were visible as errors before. I also was forced to update the`SK-dotnet.sln.DotSettings` file due to the new resharper version 2024.1 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: Roger Barreto <[email protected]>
- Loading branch information
1 parent
5438d31
commit 47c5d92
Showing
2 changed files
with
45 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters