Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance AuthProvider to support oauth2/OIDC flow #221

Merged
merged 11 commits into from
Jul 26, 2023
Merged

Enhance AuthProvider to support oauth2/OIDC flow #221

merged 11 commits into from
Jul 26, 2023

Conversation

jowilf
Copy link
Owner

@jowilf jowilf commented Jul 1, 2023

close #218

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

@github-actions github-actions bot temporarily deployed to pull request July 1, 2023 20:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2023 20:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2023 20:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2023 20:14 Inactive
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (86a6044) 100.00% compared to head (eafcf5c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #221   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           68        68           
  Lines         4939      4961   +22     
=========================================
+ Hits          4939      4961   +22     
Files Changed Coverage Δ
starlette_admin/auth.py 100.00% <100.00%> (ø)
starlette_admin/base.py 100.00% <100.00%> (ø)
starlette_admin/contrib/odmantic/admin.py 100.00% <100.00%> (ø)
starlette_admin/contrib/sqla/admin.py 100.00% <100.00%> (ø)
starlette_admin/helpers.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@simonsax simonsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it with my project and was able to implement oauth2 authentication. Thanks a lot!

examples/authlib/provider.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 22, 2023 19:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 22, 2023 20:46 Inactive
@sternalon
Copy link

Looking forward to this one being merged into the main branch!

@github-actions github-actions bot temporarily deployed to pull request July 26, 2023 16:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 26, 2023 16:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 26, 2023 19:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 26, 2023 19:59 Inactive
@jowilf jowilf merged commit e6ea924 into main Jul 26, 2023
8 checks passed
@jowilf jowilf mentioned this pull request Jul 26, 2023
@jowilf jowilf deleted the oauth2-oidc branch July 26, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add option to authenticate via oauth2/OIDC instead of username/password
3 participants