-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/windows #44
Feature/windows #44
Conversation
abdheshnayak
commented
Feb 14, 2024
- Added source in search to support multiple binary names on same repo.
- Added ps1 to work with PowerShell.
Thanks for the PR :) is there a particular reason we need to use |
The repository can be monolithic where multiple binaries can be distributed so, that's why I introduced source where users can provide the name of binary. And It will filter and download the exact binary. For example: Where the repository is going to distribute two binaries kl and kli. |
Please review and if there is something wrong, you can mention i will update it so you can accept the pull request. In case of pr is not that useful or something else please do close the pr by providing your feedback. |
I would like to add windows support to installer, but I would also like it be high-quality, and work the same way as the bash script installer. currently:
(1) change would be:
I would consider multi-binary downloads as an extra feature - though it should work the same way as it does in bash
(2) change would be to add a method to the
(3) change is optional, and it would be to support multiple archive types. id accept the PR if it only supported lastly, i am very short for time at the moment! so I may not respond quickly |
|
||
$urlamd64 = "{{$urlamd64}}" | ||
$urlarm64 = "{{$urlarm64}}" | ||
$destinationPath = "$env:USERPROFILE\Documents\kl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noticed, Documents\kl
?
is there a standard place to put EXEs in windows? in linux its one of the bins, most commonly /usr/local/bin
Pull Request #46 embodies similar functionalities to this, yet it demonstrates an enhanced level of code quality. In light of this, and to maintain the integrity and optimization of the project's codebase, I propose the closure of this pull request. This decision is made with the consideration of ensuring that we adopt the most efficient and well-structured solutions. |