Add ObservableVectorTransaction #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
force-pushed
the
vec-txn
branch
2 times, most recently
from
1adb452
to
b823345
Compare
It doesn't match the upcoming changes to VectorSubscriber.
jplatte
commented
Sep 6, 2023
Hywan
approved these changes
Sep 7, 2023
Also, remove impl Stream for VectorSubscriber in favor of two separate stream types, one mirroring the previous implementation and one that's outputs batches, making it much easier to ensure that multiple diffs of one transaction are handled as one unit.
No need to link to a type that's linked through the function signature anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eyeball-imchanges are done, but this is missing:im-util'sFilterandFilterMaptoVec<VectorDiff<T>>streams