Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

im-util: Rename DynamicLimit => Limit and add more constructors #36

Merged
merged 1 commit into from
Sep 15, 2023
Merged

im-util: Rename DynamicLimit => Limit and add more constructors #36

merged 1 commit into from
Sep 15, 2023

Conversation

jplatte
Copy link
Owner

@jplatte jplatte commented Sep 15, 2023

  • DynamicLimit => Limit because the limit can be static
  • DynamicLimit::new => Limit::dynamic
  • Limit::new for a static limit constructor
  • Limit::dynamic_with_initial_limit for starting with a non-empty vector

@jplatte jplatte requested a review from Hywan September 15, 2023 11:22
Hywan
Hywan reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! A couple of tests with Limit::new and Limit::dynamic_with_initial_limit wouldn't hurt I guess :-).

@jplatte
im-util: Rename DynamicLimit => Limit and add more constructors
ce1896b 
- DynamicLimit => Limit because  the limit can be static
- DynamicLimit::new => Limit::dynamic
- Limit::new for a static limit constructor
- Limit::dynamic_with_initial_limit for starting with a non-empty vector
@jplatte jplatte requested a review from Hywan September 15, 2023 11:57
@jplatte jplatte mentioned this pull request Sep 15, 2023
Merged
Hywan
Hywan approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jplatte jplatte merged commit ce1896b into main Sep 15, 2023
4 checks passed
@jplatte jplatte deleted the im-util-ctors branch September 15, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplatte @Hywan