fix: change port to work with maestro >= 1.37.0 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change. Maestro 1.36.0 and before uses port 22087 by default. Maestro version 1.37.0 and beyond use 7001 For details see: - jpudysz#16 - mobile-dev-inc/maestro#1816
|
Hey @joepatosh really appreciate it! Let’s wait for the Maestro team to leave some notes on your ticket linked above. If that’s intended we can safely merge it and leave info that newest version supports only v.1.37.x+! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16 but will break on Maestro v1.36.0 and earlier.
This is a breaking change. Maestro 1.36.0 and before uses port 22087 by default. Maestro version 1.37.0 and beyond use 7001
For details see:
As I explained in #16, I'm not sure if this change is worth making. Not only does it break support for Maestro v1.36.0 - I also have doubts it will work on maestro cloud due to the change made in mobile-dev-inc/maestro#1732 to add sharding / parallel execution. I'm also not sure the change to port 7001 was intended by the maestro maintainers. It seemed like a side-effect of the change to add sharding. I would not be surprised if they changed it back.
I'm opening it in case it is helpful for the maintainers of this package or other people stuck on this problem. However, it seems that a more robust solution for this package to work will require a larger change that checks multiple ports as explained here.
I appreciate @jpudysz for making this library and wanted to show my thanks by offering this contribution. Ultimately, I will defer to @jpudysz to make the judgement call on whether this PR should be merged or if a different approach should be taken instead.