Skip to content

Commit

Permalink
feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jriddle-linode committed Aug 28, 2023
1 parent accec22 commit 87544a0
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions plugins/modules/ip_assign.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,21 +93,9 @@ def exec_module(self, **kwargs: Any) -> Optional[dict]:
linode = Instance(self.client, assignment["linode_id"])
linode._api_get()
if assignment["address"] in self.flatten_ips(linode.ips):
self.fail(
msg=f"IP: {assignment['address']} already assigned to instance: {assignment['linode_id']}"
)
return self.results

self.client.networking.ips_assign(region, *assignments)
self.register_action(f"IP assignments completed: {assignments}")

for assignment in assignments:
linode = Instance(self.client, assignment["linode_id"])
linode._api_get()
if assignment["address"] not in self.flatten_ips(linode.ips):
self.fail(msg=f"IP assignments not changed: {assignments}")
self.results["changed"] = False
return self.results
except Exception as exc:
self.fail(msg=f"failed to set IP assignments {assignments}: {exc}")

Expand Down

0 comments on commit 87544a0

Please sign in to comment.