Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Adding logic fallback for image/picture/jumbotron #351

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

haricot
Copy link
Contributor

@haricot haricot commented Oct 20, 2019

No description provided.

@haricot haricot changed the title Adding fallback logic/logo for image/picture/jumbotron Adding logic fallback for image/picture/jumbotron Oct 23, 2019
@jrief
Copy link
Owner

jrief commented Oct 23, 2019

I somehow don't like to use random colors as fallback. Reason is that it adds a layer of unpredictability to the outcome. If a users want randomness, he shall explicitly set it.

Could you please explain what this PR does. A few lines of text would be great.

Thanks

@haricot haricot changed the title Adding logic fallback for image/picture/jumbotron WIP Adding logic fallback for image/picture/jumbotron Oct 23, 2019
@haricot
Copy link
Contributor Author

haricot commented Oct 24, 2019

The goal is to have fallbacks with the widths and heights most resembling possible.
I try to redo it differently.
I delete the random color which is useless because there are random x y for logos, which makes it possible to differentiate the images, as in a carousel.

Django template don't accepts key with underscore.
Django template don't accepts key with a underscore.
@haricot
Copy link
Contributor Author

haricot commented Oct 25, 2019

Accurate Fallback image: (also work when resize window)
accurate_fallback_image

@haricot
Copy link
Contributor Author

haricot commented Oct 26, 2019

Accurate Fallback picture: (also work when resize window, we do not see the logos because the image origin is big)
Acurate_fallback_picutre3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants