-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Compact admin form UI with widgets attributes #368
Open
haricot
wants to merge
35
commits into
jrief:master
Choose a base branch
from
haricot:widget_attrs_group_nested
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update branch(refactor common functionality into utility module)
haricot
force-pushed
the
widget_attrs_group_nested
branch
3 times, most recently
from
March 5, 2020 15:40
d02eb43
to
d7f34cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same layout as related #365
This uses a widgets attributes for nested fields organized with specific helpers.
Be enabled with the environment variable:
COMPACT_FORM=True
(I tried with app_settings, but it doesn't work in CascadeUtilitiesMixin due to translation)The widget cascade selector icon is associated with HTML / CSS / SVG and the fieldsets are defined according to the nested widget attribute group.
And this use a pull request #367 which also gives the possibility of filtering the fields for CascadeUtilitiesMixin.