Change OSX CD to build a universal binary #190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR follows up on #186 to address the CD build for versions of OSX prior to 11. CD now builds two version of wxWidgets and two versions of Logo for OSX, using matrix builds to target x86 and ARM. It then adds a stage which takes the individual platform builds of OSX Logo and combines them into a universal binary build.
Caveats
Size - this does result in a larger application file; I think there may be value in checking what can be disabled in the wxWidgets build without impacting the parts of wxWidgets used by UCB Logo.
Duplicate build logic - I'd like to not replicate the portion of the Makefile which builds the DMG into the CD file; but, I ran into some challenges in solving that and would like to mull some more. My thinking is that, in the meantime, this change will restore CD to working for the platforms it was previously working for. Understood if folks would like to hold off until the two places can be unified appropriately.
Testing
Downloaded the universal binary produced by the CD pipeline and was able to run it on both platforms. Checked via command line that OSX sees this as a universal binary:
Test Environments