Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sample launch code for database_talker #1792

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Apr 25, 2023

<launch>
  <param name="robot/name" value="strelka" />
  <include file="$(find jsk_robot_startup)/launch/lifelog.launch" >
    <arg name="logger_save_action" value="true" />
    <arg name="logger_save_smach" value="true" />
    <arg name="logger_save_faces" value="true" />
    <arg name="logger_save_dialogflow" value="true" />
    <arg name="image" value="/usb_cam/image_raw" />
  </include>
  <include file="$(find jsk_robot_startup)/launch/interaction.launch" >
    <arg name="chat_use_helper" value="false" />
  </include>
  <include file="$(find jsk_perception)/launch/vqa.launch" >
    <arg name="host" value="133.11.216.160" />
    <arg name="port" value="8888" />
    <arg name="run_api" value="false" />
  </include>
  <include file="$(find jsk_perception)/launch/classification.launch" >
    <arg name="host" value="133.11.216.160" />
    <arg name="port" value="9999" />
    <arg name="run_api" value="false" />
  </include>

</launch>

need

https://drive.google.com/file/d/1uctY9KmmQCFbHjRF-1LXDpBSDFy8AXL1/view?usp=share_link

Comment on lines +42 to +60
<!-- openai_ros -->
<group ns="openai">
<node pkg="openai_ros" type="openai_node.py" name="openai" output="screen">
<rosparam command="load" file="$(arg openai_credentials_json)" />
</node>
</group>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment.
I think it may be good to put sample launch files in jsk_robot, but I am also worried about an additional dependency that is not managed by jsk-ros-pkg.

<include file="$(find dialogflow_task_executive)/launch/dialogflow_ros.launch">
<arg name="credential" value="$(arg google_credentials_json)" />
<arg name="project_id" value="collaborative-remembering-kwit" />
<arg name="enable_hotword" value="false" />
Copy link
Member

@tkmtnt7000 tkmtnt7000 Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add

<arg name="override_project_id" value="true" />

Use jsk-ros-pkg/jsk_3rdparty#460

Copy link
Member

@tkmtnt7000 tkmtnt7000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When related PRs in jsk_recognition and jsk_3rdparty merge, we can merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants