[jsk_pr2_startup] Add check_hokuyo_scan_node.py #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kanazawanaoaki
force-pushed
the
add-check-base-scan-node
branch
3 times, most recently
from
2e029d7
to
cef39d0
Compare
Kanazawanaoaki
force-pushed
the
add-check-base-scan-node
branch
from
cef39d0
to
50d8c83
Compare
Kanazawanaoaki
changed the title
mqcmd196
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Confirmed to work in PR1040, LGTM
@708yamaguchi @nakane11
Are there any hokuyo problems with PR1012?
|
No problem. |
mqcmd196
merged commit df0d0a8
into
jsk-ros-pkg:develop/pr2-noetic
4 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1920 , I wrote a program to kill
base_hokuyo_node, resetbase_hokuyo, and restartbase_hokuyo_nodewhen/base_scantopic is not subscribed for a certain time (10 seconds).This program was written with reference to check_openni_node.py, and hokuyo's reset script is downloaded from the file attached to the following ros wiki page.
https://wiki.ros.org/hokuyo_node/Troubleshooting/#A.5B0-.3E75.5D_Code