Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#73 How to read this document #80

Merged
merged 9 commits into from
Aug 29, 2022
Merged

#73 How to read this document #80

merged 9 commits into from
Aug 29, 2022

Conversation

anatoly-scherbakov
Copy link
Contributor

@anatoly-scherbakov anatoly-scherbakov commented Aug 27, 2022 •
edited by pr-preview bot
Loading

Introduce the How to read this document section and a stub for Primer section as per #73.

@juusoautiosalo fyi :) For some reason I cannot request review from you.

Preview | Diff

@anatoly-scherbakov anatoly-scherbakov self-assigned this Aug 27, 2022
TallTed
TallTed requested changes Aug 27, 2022
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@gkellogg
Copy link
Member

Introduce the How to read this document section and a stub for Primer section as per #73.

@juusoautiosalo fyi :) For some reason I cannot request review from you.

Juuso needs to be added as a contributor to the repository, which I can take care of.

anatoly-scherbakov and others added 4 commits August 28, 2022 14:25
@anatoly-scherbakov @TallTed
Update spec/index.html
2506305 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@anatoly-scherbakov @TallTed
Update spec/index.html
e7c47fd 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@anatoly-scherbakov @TallTed
Update spec/index.html
d8b078c 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@anatoly-scherbakov @TallTed
Update spec/index.html
369c544 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
gkellogg
gkellogg approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an important piece, thanks for adding. I support @TallTed's suggested changes. I am a bit suspect that non-IT professionals can effectively make use of this without also understanding the core principles of JSON-LD.

anatoly-scherbakov and others added 4 commits August 29, 2022 09:16
@anatoly-scherbakov @TallTed
Update spec/index.html
06a0b58 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@anatoly-scherbakov @TallTed
Update spec/index.html
330102a 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@anatoly-scherbakov @TallTed
Update spec/index.html
9e54241 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@anatoly-scherbakov @TallTed
Update spec/index.html
aa267fa 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@anatoly-scherbakov anatoly-scherbakov merged commit d5c0c03 into spec-progress Aug 29, 2022
@TallTed TallTed mentioned this pull request Aug 29, 2022
Closed
@juusoautiosalo juusoautiosalo mentioned this pull request Aug 31, 2022
Open
@gkellogg gkellogg deleted the issue-73-how-to-read-this-document branch June 12, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed requested changes

@gkellogg gkellogg gkellogg approved these changes

Assignees

@anatoly-scherbakov anatoly-scherbakov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anatoly-scherbakov @gkellogg @TallTed