Add pre build hook #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JafarAbdi
commented
Apr 23, 2024
| @@ -53,6 +53,10 @@ If set, this branch will be used to push the packages instead of `DEB_DISTRO-ROS | |||
|
|
|||
| If set to true, Git Large File Storage will be used to store the generated binaries. | |||
|
|
|||
| ## ``PRE_BUILD_HOOK`` | |||
|
|
|||
| TODO | |||
jspricke
reviewed
Apr 23, 2024
|
|
||
| if [ -n "$PRE_BUILD_HOOK" ]; then | ||
| echo "Run pre-build hook" | ||
| eval "$PRE_BUILD_HOOK" |
There was a problem hiding this comment.
I wonder if it is better to run a script here.
There was a problem hiding this comment.
I had the same thought in mind, the user specifies a path to a script that get executed rather than a string. Do you want me to update it?
There was a problem hiding this comment.
would be great if you could do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, forgot to open the PR before