Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add --install-python=false to install invocation. #85

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix: Add --install-python=false to install invocation. #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b956493
fix: Add `--install-python=false` to install invocation.
fiadliel Oct 12, 2023
86b2499
fix: only install python on necessary versions
jthegedus Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- [Dependencies](#dependencies)
- [Install](#install)
- [Why?](#why)
- [Supported Versions](#supported-versions)
- [Default Cloud SDK Components](#default-cloud-sdk-components)
- [Contributing](#contributing)
- [License](#license)
Expand Down Expand Up @@ -53,6 +54,10 @@ The asdf config file, `.tool-versions`, allows pinning each tool in your project

When you update a version in `.tool-versions`, `asdf` will prompt all users who do not have the correct versions to upgrade. This enables whole teams to update their tools in unison.

# Supported Versions

gcloud releases from 352.0.0 and higher can be installed.

# Default Cloud SDK Components

`asdf-gcloud` can automatically install a set of Cloud SDK Components after each `asdf install gcloud <version>`. To enable this feature you must have a file that lists one COMPONENT_ID per line. For example:
Expand Down
6 changes: 5 additions & 1 deletion bin/install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ install_gcloud() {
log_success "extracted!"

log_info "🚧 installing..."
"${ASDF_INSTALL_PATH}/install.sh" --usage-reporting=false --path-update=false --quiet
jthegedus marked this conversation as resolved.
Show resolved Hide resolved
if [[ "${ASDF_INSTALL_VERSION}" > "352.0.0" ]]; then
"${ASDF_INSTALL_PATH}/install.sh" --usage-reporting=false --path-update=false --install-python=false --quiet
else
"${ASDF_INSTALL_PATH}/install.sh" --usage-reporting=false --path-update=false --quiet
fi
# test executable
test -x "${ASDF_INSTALL_PATH}/bin/gcloud" || log_failure_and_exit "Expected ${ASDF_INSTALL_PATH}/bin/gcloud to be executable."
log_success "gcloud ${ASDF_INSTALL_VERSION} installed!"
Expand Down