svc/windows: support closing via context.Done() #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@judwhite oops oversight on my part for not including this in the first round - I don't have an environment to test this from so flying a little blind here, but from a read of the code i think this will work for running on windows (easy case) and running as a service (a few more moving parts). |
|
@judwhite let me know if you have any feedback on this - or if you notice anything i need to adjust. |
|
@jehiah I think it looks good. I'm going to do some testing and hopefully get it merged/tagged in the next couple days. Thanks for the ping. |
|
Hey @judwhite i want to follow up on this thread - Is there any additional work i can do here to help? |
|
@jehiah I'm going to add some tests before tagging this. Thanks for the change, I apologize for the delay |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides support for closing a windows service, and a program running on windows via context.Done() matching non-windows functionality from #13
Closes #14