call service.Context() after service.Init() on windows #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
service.Context() is called after Init() (and after Start()) on unixes, so some users did not expect or test with Context() called before Init()
|
Ahh right, thanks. |
|
It would make sense to also move the call to ... and also that's theoretically a backwards-compatibility break for unix programs using go-svc that depended on Context() being called after Start() ... but it seems pretty unlikely that some project would use go-svc but not care that the windows case is broken ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service.Context() is called after Init() (and after Start()) on unixes,
so some users did not expect or test with Context() called before Init()
this was noticed in nsqio/nsq#1359
and is still needed along with nsqio/nsq#1361
cc @mreiferson @judwhite