Skip to content

Commit

Permalink
fix(agents-api): Fix wait for input step (#522)
Browse files Browse the repository at this point in the history
<!-- ELLIPSIS_HIDDEN -->



> [!IMPORTANT]
> Removes unnecessary transition call in `WaitForInputStep` case in
`TaskExecutionWorkflow.run()` and updates tests accordingly.
> 
>   - **Behavior**:
> - Removes `await transition(context, type="wait", output=output)` from
`WaitForInputStep` case in `run()` in `__init__.py`.
>   - **Tests**:
> - Updates `test_execution_workflow.py` to ensure workflow behaves
correctly without the removed transition call.
> 
> <sup>This description was created by </sup>[<img alt="Ellipsis"
src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=julep-ai%2Fjulep&utm_source=github&utm_medium=referral)<sup>
for 6600cee. It will automatically
update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
  • Loading branch information
HamadaSalhab authored Sep 26, 2024
1 parent ed33cf9 commit 833433a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions agents-api/agents_api/workflows/task_execution/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,6 @@ async def run(
case WaitForInputStep(), StepOutcome(output=output):
workflow.logger.info("Wait for input step: Waiting for external input")

await transition(context, type="wait", output=output)

result = await workflow.execute_activity(
task_steps.raise_complete_async,
args=[context, output],
Expand Down
1 change: 0 additions & 1 deletion agents-api/tests/test_execution_workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -1085,4 +1085,3 @@ async def _(
mock_run_task_execution_workflow.assert_called_once()

await handle.result()

0 comments on commit 833433a

Please sign in to comment.