Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Minor fix to docker bake github actions #529

Merged
merged 8 commits into from
Sep 28, 2024
Merged

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Sep 28, 2024

  • feat: Add docker bake builder
  • fix: Minor fix to agents-api/Dockerfile
  • fix: Minor fix to docker bake github actions

Important

Introduce Docker Bake for image building, update Dockerfiles, and modify GitHub Actions workflows for Docker image management.

  • GitHub Actions:
    • Add docker-bake-on-pr.yml for baking images on pull requests.
    • Rename dev-push-to-hub.yml to bake-push-to-hub.yml and main-push-to-hub.yml to latest-push-to-hub.yml.
    • Update bake-push-to-hub.yml and latest-push-to-hub.yml to use docker/bake-action@v5 and remove branch name and git sha setting steps.
  • Dockerfiles:
    • Update agents-api/Dockerfile and related Dockerfiles to use poetry>=1.8.0,<1.9.0 and set PYTHONUNBUFFERED=1.
    • Add syntax and error check directives to Dockerfiles in agents-api, gateway, integrations-service, and memory-store.
    • Modify gateway/Dockerfile to include environment variable expectations and update entrypoint script.
  • Configuration:
    • Add docker-bake.hcl to define build contexts and tags for Docker images.
  • Documentation:
    • Update CONTRIBUTING.md with instructions for building Docker images using Docker Buildx Bake.

This description was created by Ellipsis for 93dd892. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0e1a5c6 in 12 seconds

More details
  • Looked at 664 lines of code in 17 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. memory-store/Dockerfile:5
  • Draft comment:
    Consider adding a comment to periodically update the COZO_COMMIT to include the latest changes from the CozoDB project.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The Dockerfile uses a specific commit hash for the CozoDB repository. This is good for reproducibility, but it might be worth mentioning in the comments that this should be updated periodically to include the latest changes and improvements from the CozoDB project.

Workflow ID: wflow_BNhLHEfewiXa2irr


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on f1f096e in 10 seconds

More details
  • Looked at 49 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/docker-bake-on-pr.yml:38
  • Draft comment:
    Ensure consistency in cancel-in-progress condition across workflows. It should be based on the event name.
  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_JFtMHU4sPg1SUiOD


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 876b48e in 12 seconds

More details
  • Looked at 50 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_W4vuvB9Rr4PWX9YD


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on f4c66ed in 9 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/docker-bake-on-pr.yml:31
  • Draft comment:
    Consider using github.ref_name instead of github.ref for the concurrency group to avoid potential issues with long branch names or special characters.
  group: ${{ github.workflow }}-${{ github.ref_name }}
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the TAG format is appropriate for ensuring unique tags for each run attempt, which is useful for debugging and tracking purposes. However, the concurrency group definition might not be optimal.

Workflow ID: wflow_quNAgRhmj5aRi737


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 93dd892 in 11 seconds

More details
  • Looked at 27 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/bake-push-to-hub.yml:38
  • Draft comment:
    Using ${{ github.ref_name }} for the TAG allows for dynamic tagging based on the branch or tag name, which is a good improvement.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change from a fixed 'dev' tag to using github.ref_name allows for more dynamic tagging based on the branch or tag name, which is a good improvement.

Workflow ID: wflow_UyiFuIHUP4Rwg8Jg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit de2be8b into dev Sep 28, 2024
5 of 6 checks passed
@creatorrr creatorrr deleted the x/fix-docker-bake branch September 28, 2024 16:21
Vedantsahai18 pushed a commit that referenced this pull request Sep 28, 2024
  - **GitHub Actions**:
    - Add `docker-bake-on-pr.yml` for baking images on pull requests.
    - Rename `dev-push-to-hub.yml` to `bake-push-to-hub.yml` and `main-push-to-hub.yml` to `latest-push-to-hub.yml`.
    - Update `bake-push-to-hub.yml` and `latest-push-to-hub.yml` to use `docker/bake-action@v5` and remove branch name and git sha setting steps.
creatorrr added a commit that referenced this pull request Sep 30, 2024
  - **GitHub Actions**:
    - Add `docker-bake-on-pr.yml` for baking images on pull requests.
    - Rename `dev-push-to-hub.yml` to `bake-push-to-hub.yml` and `main-push-to-hub.yml` to `latest-push-to-hub.yml`.
    - Update `bake-push-to-hub.yml` and `latest-push-to-hub.yml` to use `docker/bake-action@v5` and remove branch name and git sha setting steps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant