Update generate_openapi_code.sh

[RAVI-PRAVEEN]

Key Changes:
Modular Functions: The script is now organized into functions for logging actions, compiling TypeSpec, and running Poetry tasks. Logging: Introduced log_action for logging actions and errors with timestamps. This helps track what the script is doing in real-time. Error Handling: Added || { ... } constructs to gracefully handle errors and log them. Optional Poetry Update: The --update-poetry flag is available to update Poetry dependencies before running tasks. If not passed, Poetry runs without updating. Execution Time: Logs the total time taken for the script to execute, making it easier to track performance.

---

Important

Refactor generate_openapi_code.sh to modularize functions, add logging, improve error handling, and introduce optional Poetry update flag.

• Modularization:
  • Split script into functions: log_action, compile_typespec, run_poetry_tasks, and usage.
• Logging:
  • Added log_action() to log actions with timestamps to script.log.
  • Logs start and end time of script execution.
• Error Handling:
  • Added || { ... } constructs for error handling in compile_typespec and run_poetry_tasks.
• Optional Poetry Update:
  • Introduced --update-poetry flag to optionally update Poetry dependencies.
• Misc:
  • Added usage instructions for script options.

^{This description was created by for 543f189. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 543f189 in 24 seconds

More details

• Looked at 104 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. scripts/generate_openapi_code.sh:4

• Draft comment:
  The 'set -xe' command is redundant because 'set -e' is already used, and 'set -x' is not necessary for logging purposes since the script already logs actions. Consider removing 'set -xe'.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment is addressing a change in the script where 'set -xe' is used. The script does have logging, which might reduce the need for 'set -x', but 'set -xe' is often used together for error checking and debugging. The comment is suggesting a code change, which aligns with the rules for keeping comments.
  The comment assumes that logging completely replaces the need for 'set -x', which might not be true if detailed command tracing is needed for debugging. The comment might be too quick to suggest removal without considering the debugging benefits of 'set -x'.
  While logging provides some visibility, 'set -x' offers a different level of detail that can be useful. However, if the logging is deemed sufficient, the comment's suggestion could be valid.
  The comment is about a change made in the diff and suggests a potential code improvement. It should be kept as it proposes a specific action to consider.

Workflow ID: wflow_KACHeq9QRgXodOwm

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[creatorrr]

Have you verified if the bash script works correctly? Please post output here that it does and I'd be happy to merge this pr

[creatorrr]

Duplicate of #547