Set minSdkVersion 23 and delete old encryption codes #814
+224
−408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji-1009
changed the title
|
In order to support this, the KeyCipher and StorageCipher settings must be set to the new ones in advance. Since the developer needs to update the options in advance, I assume that the PR cannot be merged. For this reason, I have closed the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #769
Two updates are planned in flutter_secure_storage v10.
This PR is a cutout of only the part about updating the min sdk to 23.
Many of the problems associated with #769 are related to old encryption codes. On the other hand, the min sdk has been updated to 21 since flutter 3.22, so there is less reason to support older Android OS.
https://docs.flutter.dev/release/breaking-changes/android-kitkat-deprecation
For this reason, can we proceed with updating the min sdk and replacing EncryptedSharedPreferences separately?
If we can update the min sdk to 23 and release it as flutter_secure_storage v9.3.0, we can close the issue about the old encryption codes.