Removed dependency on cURL #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmromanov
force-pushed
the
feature/curl-dependency
branch
from
2dc3499
to
526509d
Compare
Current coverage is 81.32% (diff: 94.44%)@@ master #8 diff @@
==========================================
Files 8 8
Lines 1283 1269 -14
Methods 52 52
Messages 0 0
Branches 0 0
==========================================
- Hits 1046 1032 -14
Misses 237 237
Partials 0 0
|
dmromanov
force-pushed
the
feature/curl-dependency
branch
from
526509d
to
eb3cdd4
Compare
|
Hi @dmromanov, this PR is good, but the Could you fix this :)? |
|
Will do this in the next two weeks. |
|
Thank you, @dmromanov 😄. |
dmromanov
force-pushed
the
feature/curl-dependency
branch
from
eb3cdd4
to
0dddefe
Compare
dmromanov
force-pushed
the
feature/curl-dependency
branch
from
0dddefe
to
6513e26
Compare
|
This is a kindly reminder that the PR was updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURL is a nice PHP extension, but if it is not present in a target system, it causes a lot of problems.