Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions in the load_session #1385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

weekenthralling
Copy link

@weekenthralling weekenthralling commented Jun 12, 2024

When refreshing the kernel, there might be other exceptions causing the refresh to fail. Perhaps catching exceptions would be more elegant.

For example:
When querying a non-existent kernel, the load_session method from the webhook returns a 404 error. If this is not handled, the final API response is a 500 error, whereas the expected response is a 404.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @weekenthralling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants