Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default CPU reporting is True #153

Closed
wants to merge 2 commits into from
Closed

Set default CPU reporting is True #153

wants to merge 2 commits into from

Conversation

duongtn811
Copy link

No description provided.

@welcome
Copy link

welcome bot commented Oct 21, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

yuvipanda
yuvipanda requested changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the very late review! But could this not be done better by setting config.track_cpu_percent's default to be True rather than False?

@frittentheke frittentheke mentioned this pull request Jul 17, 2024
Open
@krassowski
Copy link
Collaborator

@duongtn811 are you interested in finishing up this PR or should we close it?

@duongtn811 duongtn811 changed the title fix: always get cpu usage fix: set default CPU reporting is True Sep 7, 2024
@duongtn811 duongtn811 changed the title fix: set default CPU reporting is True Set default CPU reporting is True Sep 7, 2024
@duongtn811
Copy link
Author

closing this due to I can not remember the exact reason to update the default value here.

@duongtn811 duongtn811 closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda yuvipanda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@duongtn811 @krassowski @yuvipanda @duongnv81