Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more awaits for pending kernel in unit tests #654

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Jan 10, 2022

This is response to jupyter/jupyter_client#732.

jupyter/jupyter_client#732 expands the initial pending kernels work in #593 and makes "shutdown", "interrupt", and "restart" show as pending states.

Jupyter server's unit tests should await these various states when using pending kernels. Here, I've added the needed await statements and made it backwards compatible with old versions of jupyter client (before pending kernels were introduced).

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #654 (6d97b87) into main (db46446) will increase coverage by 0.02%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   77.88%   77.91%   +0.02%     
==========================================
  Files         110      110              
  Lines       10405    10418      +13     
  Branches     1400     1401       +1     
==========================================
+ Hits         8104     8117      +13     
  Misses       1911     1911              
  Partials      390      390              
Impacted Files Coverage Δ
jupyter_server/tests/services/kernels/test_api.py 96.37% <95.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db46446...6d97b87. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants