Update documentation about registering file save hooks #770
Conversation
| contents_manager.register_pre_save_hook(script_pre_save) | ||
| contents_manager.register_post_save_hook(script_post_save) | ||
|
|
||
| Hooks will then be called in the order they were registered. |
There was a problem hiding this comment.
Since we are now adding deprecation warnings for the old behavior, I would probably add this to the top of this document, and then put the current docs behind a "deprecated" note. Otherwise this looks good 👍
There was a problem hiding this comment.
Actually only the run_pre_save_hook and run_post_save_hook methods are deprecated (which are usually not used by users), but assigning to e.g. contents_manager.pre_save_hook is not deprecated yet, so I think it is too early to discourage the old behavior in the documentation, don't you think?
Codecov Report
@@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 70.36% 70.36%
=======================================
Files 62 62
Lines 7571 7571
Branches 1249 1249
=======================================
Hits 5327 5327
Misses 1860 1860
Partials 384 384 Continue to review full report at Codecov.
|
Follow-up to #696.