Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CSS variables to be used as values in the Color trait #3796

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Allow CSS variables to be used as values in the Color trait #3796

merged 1 commit into from
Jul 31, 2023

Conversation

nurbo
Copy link

@nurbo nurbo commented Jun 30, 2023

The changes allow using CSS variables to be used as values in the Color trait. Addresses #3783.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch nurbo/ipywidgets/refactor/allow-css-variables-in-color-trait

martinRenou
martinRenou reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I won't merge myself, my regex knowledge is too shallow to make a proper review

@nurbo nurbo changed the title Allow CSS variables to be used as values in the Color trait Draft: Allow CSS variables to be used as values in the Color trait Jun 30, 2023
@nurbo nurbo force-pushed the refactor/allow-css-variables-in-color-trait branch 2 times, most recently from db0d3bb to 302e12f Compare June 30, 2023 14:21
@nurbo nurbo changed the title Draft: Allow CSS variables to be used as values in the Color trait Allow CSS variables to be used as values in the Color trait Jun 30, 2023
@martinRenou martinRenou force-pushed the refactor/allow-css-variables-in-color-trait branch from 302e12f to ec9b378 Compare July 28, 2023 08:37
martinRenou
martinRenou approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Thank you for adding proper tests for this

@martinRenou martinRenou merged commit 6db437c into jupyter-widgets:main Jul 31, 2023
19 checks passed
@tfmark tfmark mentioned this pull request Apr 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nurbo @martinRenou